Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dashboard] Refactor Login layout and messaging for Gitpod Classic users #20388

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

Siddhant-K-code
Copy link
Member

@Siddhant-K-code Siddhant-K-code commented Nov 22, 2024

Description

Update the login interface to accommodate better Gitpod Classic users, including layout adjustments and new messaging about the transition to Gitpod Flex.

For more context for review, check this internal conversation

Related Issue(s)

fixes NEXT-2072

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look very neat, I like the visual cleanness a lot. Left a couple of comments regarding the copy, which I think deserves a second look.

) : (
<>
<Heading1>Log in to Gitpod Classic</Heading1>
<Subheading>Hosted by us</Subheading>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy nit: "Hosted by us" could theoretically also be used for Gitpod Flex. Is that intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could theoretically also be used for Gitpod Flex

I don't think so 🤔

As of now, Gitpod Flex is not "hosted" by us, it's hosted in customer's runners

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point is to highligh that workspaces are hosted by us, one does not need to self host or run on local.

I do agree it looks out of the context though. Not sure how could be rephrased better.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the runners are hosted by users, but the app people use as the primary interface is hosted by us either way. It's not clear what is "Hosted by us" exactly. This is not that big of a deal though compared to my other comment, I think we can resolve.

components/dashboard/src/Login.tsx Show resolved Hide resolved
Copy link
Member

@filiptronicek filiptronicek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Siddhant-K-code
Copy link
Member Author

/unhold

@roboquat roboquat merged commit bb65be7 into main Nov 25, 2024
33 checks passed
@roboquat roboquat deleted the login-page/non-enterprise-users branch November 25, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants